cargohold: use multi-part uploads to S3 #4548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
smatting
changed the title
Contributor
|
I wasn't able to figure out the maximum number of lightweight threads the |
Member
I think there is no maximum. Perhaps we should just use |
akshaymankar
approved these changes
Apr 24, 2025
Member
akshaymankar
left a comment
akshaymankar
left a comment
There was a problem hiding this comment.
Looks good!
Feel free to tweak the default memory requests and limits separately.
Member
Author
|
It seems our concurrent uploads per second are not very high; so current limits should be okay. We should monitor and increase if we discover OOMkills. |
This was referenced May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way assets are uploaded to S3.
This PR makes use of multi-part uploads API via the
amazonka-s3-streaminglibrary.6 MB(not possible to decrease). For comparison, we were using chunks of128 KBfor the body before.Checklist
changelog.dContext:
cargohold needs to be compatible with StorageGRID.
Without this PR cargohold receives 400 Bad request when uploading. It might be related to this comment:
: https://docs.netapp.com/us-en/storagegrid/s3/s3-rest-api-supported-operations-and-limitations.html#common-request-headers
Switching to multi-part uploads seems to fix the problem.
See also https://wearezeta.atlassian.net/browse/WPB-17236