Skip to content

Add a webapp url field to email domain registration #4542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
supersven wants to merge 22 commits into from
Closed

Add a webapp url field to email domain registration #4542

supersven wants to merge 22 commits into from

Conversation

@supersven
Copy link
Contributor

@supersven supersven commented Apr 15, 2025 •
edited
Loading

Ticket: https://wearezeta.atlassian.net/browse/WPB-17032

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines
  • Run make git-add-cassandra-schema to update the cassandra schema documentation

@supersven
Deprecate original domain-verification/.*/backend endpoint
9dd6e85 
The payload format will change with V9.
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 15, 2025
supersven added 21 commits April 15, 2025 11:33
@supersven
Add V9 endpoint, prepare for changed payload
1f0afe5
@supersven
Add some haddock
7c11c4d
@supersven
Let the V9 payload be exactly like V8
0547a9d 
... and adjust it in a next step.
@supersven
Scratch out V9 config json format
87a57e2
@supersven
Equal service definitions for V8 and V9
227ed29
@supersven
Hand the webapp URL down to the database
8c67d1f
@supersven
Limit the old get-domain-verification endpoint to <= v8
eb5959e 
Make space for V9 with a new response payload.
@supersven
Use the V8 handler for V9
144a7de 
We'll work on the same data, only the serialization will differ.
@supersven
Add webapp_url to the output
72e636c 
Finally, it's optional and doesn't hurt.
@supersven
Use Versioned in updateDomainRedirect
108f657 
Test 8 (representing the old handler) and the current version
(representing the new handler.)
@supersven
Make webappUrl mandatory for V9
aaf2441
@supersven
The V8 type synonym didn't work out... Remove it
d00745f 
Finally, the webapp url is mandatory in the V9 API.
@supersven
Change format of get-domain-registration (V9)
539c542 
Add the webapp URL and change the structure according to the spec.
@supersven
Adjust (c)opyright
4ee1459
@supersven
Delete old TODO
28c178f
@supersven
Add comment
0209259
@supersven
run make git-add-cassandra-schema
a06d49b
@supersven
Adjust DomainRegistrationResponse to new config scheme
13df7c2 
This affects the unversioned stern endpoint "domain-registration-get".
@supersven
Version get-all-registered-domains
b4b9edc
@supersven
Adjust golden tests for DomainRegistrationResponse & DomainRegistrati…
9ceb831 
…onUpdate
@supersven
Ensure the old rendering format for DomainRegistrationResponseV8
5c81336
@supersven supersven mentioned this pull request Apr 30, 2025
Merged
3 tasks
@supersven
Copy link
Contributor Author

supersven commented May 12, 2025

Has been split up and superseded by:

@supersven supersven closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@supersven @zebot