Skip to content

Verify commit leaf nodes #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcapriotti merged 20 commits into from
Apr 24, 2025
Merged

Verify commit leaf nodes #4531

pcapriotti merged 20 commits into from
Apr 24, 2025

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Apr 8, 2025 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-16929

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti force-pushed the verify-commit-leaf-nodes branch from 33bfe48 to e3106b6 Compare April 10, 2025 06:46
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 10, 2025
@pcapriotti pcapriotti force-pushed the verify-commit-leaf-nodes branch 3 times, most recently from 7952036 to f25e828 Compare April 16, 2025 09:24
@pcapriotti pcapriotti force-pushed the verify-commit-leaf-nodes branch from c44c638 to ce27b3e Compare April 22, 2025 11:40
@pcapriotti pcapriotti marked this pull request as ready for review April 24, 2025 07:02
@pcapriotti pcapriotti requested review from a team as code owners April 24, 2025 07:02
@pcapriotti pcapriotti force-pushed the verify-commit-leaf-nodes branch from 44fa235 to 636db38 Compare April 24, 2025 07:02
pcapriotti added 19 commits April 24, 2025 09:16
@pcapriotti
Remove duplication in checkProposal
d6078d0
@pcapriotti
Check signature keys of leaf nodes in internal commits
dc4697b
@pcapriotti
Refactor createMLSClient
7a1ffdf
@pcapriotti
Migrate mls/clients test to integration
4c5ea78
@pcapriotti
Make mls/clients return only one signature key
022ed88
@pcapriotti
Remove GenericClientMap and generalise ClientMap
2f89a3a
@pcapriotti
Use Error effect in getClientInfo
1b22252
@pcapriotti
Implement signature check for update paths
ed6478f
@pcapriotti
fixup! Check signature keys of leaf nodes in internal commits
27cfece
@pcapriotti
Skip leaf node signature key check if no key can be found
f095013
@pcapriotti
Lint
814b6fd
@pcapriotti
Check leaf node of update path
6957ce2
@pcapriotti
Extract and generalise leaf node signature check
e696da8
@pcapriotti
Move new federation endpoint to V3.
0918698
@pcapriotti
fixup! Extract and generalise leaf node signature check
71dae21
@pcapriotti
Add CHANGELOG entry
ea4c0ff
@pcapriotti
Test signature keys for clients of existing users as well
0a036e8
@pcapriotti
Test incorrect signature key on external commit
20fd73b
@pcapriotti
Test compatibility with federation v1
a377a92
@pcapriotti pcapriotti force-pushed the verify-commit-leaf-nodes branch from 636db38 to d4182c0 Compare April 24, 2025 07:21
battermann
battermann approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@battermann battermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

services/brig/test/integration/API/Federation.hs Outdated
Copy link
Contributor

@battermann battermann Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this annotation needed to prevent ambiguity of c.clientId in the next line?

Copy link
Contributor Author

@pcapriotti pcapriotti Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because using a field of a value is never enough to disambiguate its type.

@pcapriotti pcapriotti force-pushed the verify-commit-leaf-nodes branch from d4182c0 to a377a92 Compare April 24, 2025 07:40
@pcapriotti pcapriotti merged commit 43d3653 into develop Apr 24, 2025
8 checks passed
@pcapriotti pcapriotti deleted the verify-commit-leaf-nodes branch April 24, 2025 09:17
@zebot zebot mentioned this pull request Apr 25, 2025
Closed
This was referenced May 12, 2025
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@battermann battermann battermann approved these changes

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pcapriotti @battermann @zebot