Skip to content

WPB-16875 team admin creates a channel without joining #4527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
battermann merged 26 commits into from
Apr 16, 2025
Merged

WPB-16875 team admin creates a channel without joining #4527

battermann merged 26 commits into from
Apr 16, 2025

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Apr 7, 2025 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-16875

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 7, 2025
@battermann battermann marked this pull request as ready for review April 9, 2025 10:28
@battermann battermann requested review from a team as code owners April 9, 2025 10:28
@battermann battermann force-pushed the WPB-16875-team-admin-creates-a-channel-without-joining branch from 9a0f5ec to dff8f26 Compare April 9, 2025 11:03
akshaymankar
akshaymankar requested changes Apr 10, 2025
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor issues, looks good for the most part.

@battermann battermann requested a review from akshaymankar April 10, 2025 11:16
battermann and others added 22 commits April 15, 2025 11:48
@battermann
wip: failing test
0cecdce
@battermann
wip: renamed CreateGroupConverstion to ...V8
66e6348
@battermann
wip: fix tests after changing the Conversation type
5b09ecc
@battermann
fix galley integration tests
3dc6f9b
@battermann
fix some brig tests
597537a
@battermann
add formJSON golden test and fix others
9a26784
@battermann
fix brig integration test
49ea728
@akshaymankar @battermann
[WIP] wire-api: Rename Conversation -> ConversationV8
b117a39 
pending: apply changes to everywhere outside wire-api
@battermann
[WIP] apply Conversation -> Conversationv8 renaming: wire-subsystems
cbb636f
@battermann
[WIP] rename conv: galley
152efba
@battermann
[WIP] rename conv: stern
20f440c
@battermann
[WIP] rename conv: brig
03c29ad
@battermann
rename conversation complete
0c823fe
@battermann
changelog
fd7aed8
@battermann
fix error after rebasing on develop
a3e9985
@battermann
rename field to members, and type to set, rename function
7a2874c
@battermann
renamed function
537bdad
@battermann
dedup'ed the code
7bf09ea
@battermann @akshaymankar
Update libs/wire-api/src/Wire/API/Conversation.hs
3ec9cdd 
Co-authored-by: Akshay Mankar <[email protected]>
@battermann @akshaymankar
Update libs/wire-api/src/Wire/API/Conversation.hs
60912ff 
Co-authored-by: Akshay Mankar <[email protected]>
@battermann @akshaymankar
Update libs/wire-api/src/Wire/API/Conversation.hs
21493d5 
Co-authored-by: Akshay Mankar <[email protected]>
@battermann
reset parallelism for integration tests
8fbdca1
@battermann battermann force-pushed the WPB-16875-team-admin-creates-a-channel-without-joining branch from 1d8d291 to 889958f Compare April 15, 2025 11:51
@battermann battermann merged commit 6e8a951 into develop Apr 16, 2025
11 checks passed
@battermann battermann deleted the WPB-16875-team-admin-creates-a-channel-without-joining branch April 16, 2025 08:43
@battermann battermann mentioned this pull request Apr 24, 2025
Merged
2 tasks
@zebot zebot mentioned this pull request Apr 25, 2025
Closed
This was referenced May 12, 2025
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@battermann @akshaymankar @zebot