Skip to content

[WPB-1216] servantify proxy (part 2, again) #4525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fisx merged 49 commits into from
Apr 14, 2025
Merged

[WPB-1216] servantify proxy (part 2, again) #4525

fisx merged 49 commits into from
Apr 14, 2025

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Apr 7, 2025 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-1216

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 7, 2025
@supersven supersven force-pushed the WPB-1216-servantify-proxy branch from 324c08b to 7b3da93 Compare April 7, 2025 14:08
@fisx fisx force-pushed the WPB-1216-servantify-proxy branch from 7b3da93 to 9ca012d Compare April 7, 2025 15:00
fisx
fisx commented Apr 9, 2025
View reviewed changes
@supersven supersven force-pushed the WPB-1216-servantify-proxy branch from f1d39da to 619b750 Compare April 9, 2025 15:07
@fisx fisx force-pushed the WPB-1216-servantify-proxy branch from 0ee65cd to 95329e9 Compare April 9, 2025 15:53
@fisx fisx marked this pull request as ready for review April 9, 2025 15:57
@fisx fisx requested review from a team as code owners April 9, 2025 15:57
@fisx
Copy link
Contributor Author

fisx commented Apr 10, 2025 

----- AssetDownload.testDownloadAssetMultiIngressS3DownloadUrl FAIL (1.65 s) -----
app failure:
Error while parsing /etc/wire/proxy/conf/proxy.yaml: YAML exception:
Yaml file not found: /etc/wire/proxy/conf/proxy.yaml

(many tests fail that way)

@supersven supersven force-pushed the WPB-1216-servantify-proxy branch from b96b793 to 84f5c5d Compare April 10, 2025 09:14
@fisx fisx force-pushed the WPB-1216-servantify-proxy branch from 7adec27 to a54ac85 Compare April 10, 2025 09:43
supersven and others added 17 commits April 14, 2025 11:49
@supersven @fisx
Make proxy config follow same schema as other services
eb4992a 
Otherwise, integration cannot patch the config correctly.
@fisx
Add /services/proxy to make cr.
be739aa
@fisx
Add integration test for giphy proxy.
d653688 
make devtest TEST_INCLUDE=testProxyGiphy now does something!
@fisx
wip
61b1140
@supersven @fisx
Add giphyEndpoint to Helm chart
1035091
@supersven @fisx
Read giphyEndpoint config option
56fe1a7
@supersven @fisx
Formatting
42fc6db
@supersven @fisx
WIP: Proxy integration test
964c30d
@supersven @fisx
Make Proxy testable
970f205 
Allow HTTP connections for tests.
@supersven @fisx
More assertions in test
28771be
@fisx
More assertions in test.
007591f
@fisx
Error case.
84e6d09
@fisx
Drop SetupHelpers.Proxied and move everything into Test.Proxy.
e9e653b
@fisx
Test more error cases.
fbc8900
@fisx
refactor: make proxy independent of wai-predicate
145fdc3
@fisx
Move giphy proxy from wai-predicate to servant.
98910ce
@fisx
TODO
c7e2163
supersven and others added 15 commits April 14, 2025 11:49
@fisx fisx force-pushed the WPB-1216-servantify-proxy branch from d2ebf2c to a9a5621 Compare April 14, 2025 09:49
supersven
supersven reviewed Apr 14, 2025
View reviewed changes
integration/test/Testlib/ModService.hs Outdated
sternCfg = setField "logLevel" ("Warn" :: String),
federatorInternalCfg = setField "logLevel" ("Warn" :: String)
federatorInternalCfg = setField "logLevel" ("Warn" :: String),
wireProxyCfg = setField "logLevel" ("Trace" :: String)
Copy link
Contributor

@supersven supersven Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set loglevel to Warn.

supersven
supersven reviewed Apr 14, 2025
View reviewed changes
@fisx fisx merged commit 98e2507 into develop Apr 14, 2025
10 checks passed
@fisx fisx deleted the WPB-1216-servantify-proxy branch April 14, 2025 11:04
@zebot zebot mentioned this pull request Apr 25, 2025
Closed
This was referenced May 12, 2025
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supersven supersven supersven approved these changes

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fisx @supersven @zebot