use latest hedis #3445
Closed
use latest hedis #3445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Member
Author
|
Does not work; hedis unit tests run forever and never stop. Code does not seem ready. |
2 tasks
jschaul
added a commit
that referenced
this pull request
Jul 19, 2023
We wish to avoid needing persistence during CI runs, as we run into limits of volume creation, which causes integration test setup failures. This PR can be reverted at some point in the future when: - hedis code is both compatible with current redis version AND redis version 7 and its tests pass, and it is released to hackage / nixpkgs. Then: - Step 1. We can use latest hedis code (and merge this to develop, ensuring this works on staging) - Step 2: Subsequently this PR can be reverted, and the redis-cluster helm chart bumped, and persistence disabled. See also #3444 - ensure to do steps 1 and 2 on *separate* PRs, to avoid requiring a redis helm chart update concurrently with a code update - that would not work well in production and cause downtime. Context: - https://wearezeta.atlassian.net/browse/WPB-2824 - https://wearezeta.atlassian.net/browse/WPB-2783 - #3427 - #3444 - #3445
jschaul
added a commit
that referenced
this pull request
Jul 19, 2023
We wish to avoid needing persistence during CI runs, as we run into limits of volume creation, which causes integration test setup failures. This PR can be reverted at some point in the future when: - hedis code is both compatible with current redis version AND redis version 7 and its tests pass, and it is released to hackage / nixpkgs. Then: - Step 1. We can use latest hedis code (and merge this to develop, ensuring this works on staging) - Step 2: Subsequently this PR can be reverted, and the redis-cluster helm chart bumped, and persistence disabled. See also #3444 - ensure to do steps 1 and 2 on *separate* PRs, to avoid requiring a redis helm chart update concurrently with a code update - that would not work well in production and cause downtime. Context: - https://wearezeta.atlassian.net/browse/WPB-2824 - https://wearezeta.atlassian.net/browse/WPB-2783 - #3427 - #3444 - #3445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3444 (but on the existing redis-cluster version, to ensure latest Haskell code is still compatible).
Checklist
changelog.d