websocket ping-pong #3047
Merged
websocket ping-pong #3047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaul
added
the
ok-to-test
jschaul
force-pushed
the
websocket-ping-pong
branch
3 times, most recently
from
c71d1d5 to
d72412d
Compare
jschaul
force-pushed
the
websocket-ping-pong
branch
from
d72412d to
2d548a2
Compare
supersven
approved these changes
Feb 16, 2023
Contributor
supersven
left a comment
supersven
left a comment
There was a problem hiding this comment.
LGTM 👍
Only two remarks that aren't mandatory to solve... (AKA nit pickings)
jschaul
force-pushed
the
websocket-ping-pong
branch
from
f25feae to
7f373ad
Compare
jschaul
force-pushed
the
websocket-ping-pong
branch
from
7f373ad to
61791b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about debugging https://wearezeta.atlassian.net/browse/FS-1489
(related ping-pong prior work: #561 and prior discussion: #560)