-
Notifications
You must be signed in to change notification settings - Fork 334
Additional redis write #2304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Additional redis write #2304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
establish connection and thread it into Gundeck's Env
I, starting connection to main-redis..., connectionMode=Cluster, connInfo=ConnInfo {connectHost = "127.0.0.1", connectPort = PortNumber 6377, connectAuth = Nothing, connectDatabase = 0, connectMaxConnections = 100, connectMaxIdleTime = 30s, connectTimeout = Just 5s, connectTLSParams = Nothing}
I, starting connection to redis in cluster mode ...
gundeck: ConnectionLost
…edis-master as secondary redis for redis migration test
Doesn't work yet due to: Warning FailedScheduling 0/5 nodes are available: 5 pod has unbound immediate PersistentVolumeClaims.
… redis?" This reverts commit 706133a.
* volumePermissions.enable make it run an initContainer which fixes the permissions on the mounted volume, so it can be accessed by the non-root user which runs redis. * persistence.size is set to 100 Mi, so it doesn't kill the cluster.
akshaymankar
approved these changes
Apr 27, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Drive-by refactoring change (not strictly needed on this PR):
Related to https://github.com/zinfra/cailleach/pull/1021
This is needed to perform a smooth no-downtime migration from one redis to another as detailed in https://github.com/zinfra/cailleach/blob/master/targets/wire/notes-redis-migration.md#how-to-migrate-traffic-from-redis-in-ec2classic-to-redis-in-eks
Checklist
changelog.d.