Skip to content

Commit f69846e

Browse files
committed
test: Address the second-pass review findings on the preflight contract
Address the three remaining findings from the cubic re-review at 2031ea6. - Add a wrong-value REPORT_PATH mutation for the node-only assertion step, locking the checker's rejection of any binding other than the uploaded outcome report path (the suite previously covered only a missing binding). - Pin the dogfood runbook's caller-workflow fetch with ?ref=main so the verified publish.yml content matches the dispatched ref. - Update the capture example's builder.version nodejs to v24.21.0, matching the example's own runner-image node_version under the observed-version equality rule; shape-only builder.version examples stay aligned with the governed fixtures. Signed-off-by: Yunseo Kim <[email protected]>
1 parent 2031ea6 commit f69846e

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

‎docs/architecture/verification-policy-and-fixtures.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ verbatim platform-provided `Included Software` URL, not a reconstructed URL.
596596
],
597597
"runDetails": {
598598
"builder": {
599-
"version": { "nodejs": "v24.0.0" },
599+
"version": { "nodejs": "v24.21.0" },
600600
"builderDependencies": [
601601
{
602602
"uri": "pkg:golang/github.com/sigstore/[email protected]",

‎docs/dogfood/npm-m1-verification-procedure.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ to the caller workflow is already confirmed working.
8080
4. Verify that the caller workflow pin equals the selected builder SHA.
8181

8282
```bash
83-
gh api repos/windlasstech/vers-js/contents/.github/workflows/publish.yml --jq '.content' | base64 -d
83+
gh api "repos/windlasstech/vers-js/contents/.github/workflows/publish.yml?ref=main" --jq '.content' | base64 -d
8484
```
8585

8686
Expected output: the decoded workflow's reusable-workflow `uses:` reference ends with the full

‎internal/workflowcheck/check_test.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,7 @@ func TestToolchainContractRejectsDrift(t *testing.T) {
430430
tests["missing github output"] = replaceOnce(t, body, ` --github-output "$GITHUB_OUTPUT"`, "")
431431
tests["missing assert report-path"] = replaceOnce(t, body, ` --node-only --report-path "$REPORT_PATH"`, " --node-only")
432432
tests["missing assert report env"] = replaceOnce(t, body, " env: {REPORT_PATH: \"${{ runner.temp }}/windlass-npm-outcome-report.json\"}\n run: go run ./cmd/slsa-builder-internal npm-profile-toolchain-assert", " run: go run ./cmd/slsa-builder-internal npm-profile-toolchain-assert")
433+
tests["wrong assert report env"] = replaceOnce(t, body, "env: {REPORT_PATH: \"${{ runner.temp }}/windlass-npm-outcome-report.json\"}\n run: go run ./cmd/slsa-builder-internal npm-profile-toolchain-assert", "env: {REPORT_PATH: \"${{ runner.temp }}/other.json\"}\n run: go run ./cmd/slsa-builder-internal npm-profile-toolchain-assert")
433434
tests["missing provision report-path"] = replaceOnce(t, body, ` --github-output "$GITHUB_OUTPUT" --report-path "$REPORT_PATH"`, ` --github-output "$GITHUB_OUTPUT"`)
434435
tests["wrong provision report env"] = replaceOnce(t, body, "env: {REPORT_PATH: \"${{ runner.temp }}/windlass-npm-outcome-report.json\"}\n run: go run ./cmd/slsa-builder-internal npm-profile-provision-npm", "env: {REPORT_PATH: \"${{ runner.temp }}/other.json\"}\n run: go run ./cmd/slsa-builder-internal npm-profile-provision-npm")
435436
} else {

0 commit comments

Comments
 (0)