Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKED ON SMA] Communicate with inverters using Speedwire instead of Modbus #16

Open
madtempest opened this issue Jul 29, 2023 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@madtempest
Copy link

Is your feature request related to a problem? Please describe:
Hi,

My request is less about a problem and more about a potential problem: the security of Modbus on home networks. I can see that you have support for the SMA Speedwire protocol to allow it to work with SMA Home Manager and given the risks of enabling Modbus (SMA themselves recommend you don't enable it and it's not enabled by default for a reason), my request is to remove any code related to Modbus and use the Speedwire protocol instead.

This will improve the security of the plugin, the inverters and people's home networks.

Describe the solution you'd like:
Remove any code related to Modbus and use the Speedwire protocol instead.

Describe alternatives you've considered:
From a security perspective, there really isn't any alternatives The SMA Speedwire protocol supports encrypted communication whereas the Modbus protocol does not. Furthermore, there is a reduced risk of accidental harm or negative impact of local broadcast or other storm traffic on a network interacting with Speedwire vs Modbus.

@madtempest madtempest added the enhancement New feature or request label Jul 29, 2023
@sbf-
Copy link

sbf- commented Jul 30, 2023

Speedwire uses the closed and thus undocumented SMAData2+ protocol
Very unlikely Wim will put any further effort into Speedwire when there is such thing as Modbus

@wimleers
Copy link
Owner

wimleers commented Aug 2, 2023

For now, I have to agree with @sbf-… as much as I would personally LOVE to move away from ModBus, the problem is indeed that the SpeedWire protocol is effectively undocumented.

Furthermore, there are significant caveats when enabling encryption for Speedwire in SMA's documentation. There's definitely no documentation for encrypted Speedwire 😞

I spent dozens of hours trying to make that work. I found some hacky reverse-engineered sample implementations, but they're not guaranteed to keep working.

If you can point me to official documentation for the (encrypted) Speedwire protocol, I'd be more than happy to change the implementation of this Homebridge plugin!

Unfortunately, SMA's actions suggest they would rather not have anybody interacting with their devices (despite the legal right to do so in the EU!) at all, let alone via widely adopted standards, or their own "standards" (which are entirely closed).

Sadly, ModBus is the only thing they explicitly support. And even then, their documentation often is not aligned with reality (see the numerous comments in index.js mentioning how the official docs indicate something ought to work but does not).

If anybody at SMA reads this: please reach out to me via https://wimleers.com/contact, and I'd be more than happy to work with you! 😊 (And modify the contents of this comment.)

@wimleers wimleers changed the title [Feature Request] Move code to use SMA Speedwire Instead of Modbus [BLOCKED ON SMA] Communicate with inverters using Speedwire instead of Modbus Aug 2, 2023
@wimleers wimleers added the help wanted Extra attention is needed label Aug 2, 2023
@wimleers
Copy link
Owner

wimleers commented Dec 7, 2023

@raimund-hdr claims at #19 (comment) that there is documentation on Speedwire.

@whistlefromthesun
Copy link

dunno where these come from - might be helpful?

sunny - 1
sunny - 3
sunny - 2
sunny - 0

@wimleers
Copy link
Owner

wimleers commented Feb 5, 2024

@whistlefromthesun Can you please upload a PDF of that? These photos full of artifacts of a PDF on a computer screen (that almost looks like a CRT screen? 😅) are very difficult to read 🤓

@sbf-
Copy link

sbf- commented Feb 5, 2024

@whistlefromthesun Can you please upload a PDF of that? These photos full of artifacts of a PDF on a computer screen (that almost looks like a CRT screen? 😅) are very difficult to read 🤓

I guess these pictures were taken by a spy at SMA premises, knowing the fact SMAdata2+ protocol is undisclosed.
Interresting info for sure, if it´s readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants