You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Low Risk
Low risk UI-only change: adds a new count-tracking field per list fragment and updates the search hint formatting; main risk is incorrect counts/strings if the new total count is not kept in sync with list reloads.
Overview
Updates the search bar hint in MainActivityModern to display "X of Y" (filtered vs total) when filter pills are active and reduce the list, while keeping the existing hint when filters are inactive or match everything.
To support this, SearchableFragment now exposes getTotalEventCount(), and the Active/Upcoming/Dismissed fragments track and return the pre-filter total during loadEvents(). Adds new search_placeholder_filtered plurals (EN + FR) and Robolectric tests covering the new hint behavior plus a test-only setter (setFilterStateForTesting) to drive filter scenarios.
Written by Cursor Bugbot for commit 8e8bd9e. This will update automatically on new commits. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
williscool
force-pushed
the
feat/search_bar_x_of_y
branch
from
fixes #241
Note
Low Risk
Low risk UI-only change: adds a new count-tracking field per list fragment and updates the search hint formatting; main risk is incorrect counts/strings if the new total count is not kept in sync with list reloads.
Overview
Updates the search bar hint in
MainActivityModernto display "X of Y" (filtered vs total) when filter pills are active and reduce the list, while keeping the existing hint when filters are inactive or match everything.To support this,
SearchableFragmentnow exposesgetTotalEventCount(), and the Active/Upcoming/Dismissed fragments track and return the pre-filter total duringloadEvents(). Adds newsearch_placeholder_filteredplurals (EN + FR) and Robolectric tests covering the new hint behavior plus a test-only setter (setFilterStateForTesting) to drive filter scenarios.Written by Cursor Bugbot for commit 8e8bd9e. This will update automatically on new commits. Configure here.