fix: fast follow bug fixes and refactors from upcoming time pill#253
Merged
williscool merged 4 commits intomasterfrom Feb 25, 2026
Merged
fix: fast follow bug fixes and refactors from upcoming time pill#253williscool merged 4 commits intomasterfrom
williscool merged 4 commits intomasterfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
android/app/src/main/java/com/github/quarck/calnotify/prefs/PreferenceUtils.kt
Show resolved
Hide resolved
android/app/src/main/java/com/github/quarck/calnotify/prefs/UpcomingTimePresetPreferenceX.kt
Show resolved
Hide resolved
Code Coverage Report
Files
|
📊 Code Coverage Summary
|
android/app/src/main/java/com/github/quarck/calnotify/prefs/UpcomingTimePresetPreferenceX.kt
Show resolved
Hide resolved
📊 Code Coverage Summary
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
android/app/src/main/java/com/github/quarck/calnotify/prefs/UpcomingTimePresetPreferenceX.kt
Show resolved
Hide resolved
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fast follow from #252
Note
Medium Risk
Changes how user-entered preset strings are parsed/normalized and how durations are rendered in the UI; mistakes could silently alter stored settings or display incorrect intervals, but scope is limited to preference/UI flows.
Overview
Improves preset handling by centralizing comma-separated preset parsing/normalization in
PreferenceUtils.normalizePresetInput, including optional filtering and tracking of dropped invalid values.Updates the snooze and upcoming-lookahead preset preference dialogs to use the shared normalization logic; upcoming presets now filter out invalid/out-of-range values and warn when entries are removed.
Makes upcoming lookahead labels localizable by adding a Context-based
formatPresetHumanReadablethat uses newpluralsresources, and wires it into the upcoming time chip and bottom sheet; also tweaks bottom-sheet radio/divider sizing via new dimens.Written by Cursor Bugbot for commit c3d38db. This will update automatically on new commits. Configure here.