refactor: Extract event key Intent format to single source of truth#231
Merged
williscool merged 1 commit intomasterfrom Jan 22, 2026
Merged
refactor: Extract event key Intent format to single source of truth#231williscool merged 1 commit intomasterfrom
williscool merged 1 commit intomasterfrom
Conversation
Added toIntentString() and fromIntentString() methods to EventAlertRecordKey class to ensure the event key format used in Intent extras is defined in one place. This prevents format mismatches between serialization and parsing. - EventAlertRecordKey.toIntentString(): Serializes key for Intent extras - EventAlertRecordKey.fromIntentString(): Parses key from Intent extras - Updated ActiveEventsFragment to use toIntentString() - Updated ApplicationController to use fromIntentString() Co-authored-by: wharris <[email protected]>
Code Coverage Report
|
📊 Code Coverage Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added toIntentString() and fromIntentString() methods to EventAlertRecordKey class to ensure the event key format used in Intent extras is defined in one place. This prevents format mismatches between serialization and parsing.
Note
Unifies the event key format used in Intent extras by making
EventAlertRecordKeythe single source of truth.toIntentString()andfromIntentString()toEventAlertRecordKeyfor Intent serialization/parsingActiveEventsFragmentwithit.key.toIntentString()when launchingSnoozeAllActivityApplicationController.snoozeSelectedEventswithEventAlertRecordKey.fromIntentString()Written by Cursor Bugbot for commit 055c440. This will update automatically on new commits. Configure here.