Repository navigation
chore: move the toolchain to Node 24 LTS and test on 22/24/26 - #318
Merged
Merged
Conversation
Node 24 is the Active LTS; 22 is in maintenance (EOL 2027-04-30) and 26 becomes Active LTS on 2026-10-28. - Workflows: node-version 22 -> 24 (ci, lighthouse, pages, update, release). The CI test job becomes a 22/24/26 matrix: 22 because the published package keeps engines.node >=22, 26 so the next switch is one line. Branch protection only requires "CI Success". - release.yml: drop `npm install -g [email protected]`. Node 24 bundles npm 11.19, which supports trusted publishing (>= 11.5.1); installing a package manager in the job holding the OIDC token was the risk the old comment described. An assertion now fails the job if the bundled npm is ever too old. - verify-package: strip npm_config_allow_scripts from child processes. npm 11.16-11.19 (Node 24's) and 12.0.x leak a user .npmrc allow-scripts into nested installs, which then fail with EALLOWSCRIPTS (npm/cli#9912). - @types/node ^22 -> ^24.19.0 (locked at 24.19.0; 24.19.1 is inside the 7-day cooldown). Dependabot comment updated. - .nvmrc (24) for local dev; AGENTS/CONTRIBUTING/CODING_STANDARDS stack versions refreshed (Node 24, TS 6.0, Vitest 5, vite 8, ESLint 10) and the runtime-dependency list corrected to include zod. engines.node stays >=22 for consumers. Co-Authored-By: Claude Opus 5.5 <[email protected]>
williamzujkowski
enabled auto-merge (squash)
October 3, 2026 18:29
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third step of the LTS refresh: the toolchain and CI move to Node 24 (Active LTS), and CI also tests on 22 and 26. The decisions behind it:
engines.node >=22until Node 22's EOL (2027-04-30). This is not a breaking change for consumers.The derived metrics were rounded first (#316), so moving the data build to Node 24 causes no dataset churn. That's verified below.
Changes
node-version: 22→24in ci, lighthouse, pages, update and release (×2)testjob[22, 24, 26],fail-fast: false. Branch protection requires onlyCI Success, which already gates onneeds.test.release.ymlnpm install --global [email protected]. Node 24 bundles npm 11.19, which supports trusted publishing (≥ 11.5.1). Fetching a package manager in the job that holds the OIDC token was the risk the old comment described, and it was the Scorecard finding dismissed earlier. A small assertion now fails the job if the bundled npm is ever < 11.5.1.scripts/verify-package.tsnpm_config_allow_scriptsfrom child processes. npm 11.16–11.19 (Node 24's) and 12.0.x leak a user.npmrcallow-scriptsinto nested installs, which then fail withEALLOWSCRIPTS(npm/cli#9912, fixed in 11.20.0 / 12.1.0). This is the--allow-scriptserror seen locally.@types/node^22→^24.19.0, locked at 24.19.0 (24.19.1 is inside the 7-day cooldown). Dependabot comment updated..nvmrc24, for local devzod, which has been a production dependency since v0.1.0 (the public API exports the schemas) but was missing from the docs.Not changed, and why
typescript <6.1.0(#10940; TS 7.1 support is in review), andastro checkcan't run on TS 7 (astro/check thinks typescript is not installed when using TypeScript 7 withastro/astro#17268). We're on the latest 6.x (6.0.3).engines.nodestays>=22.Test plan
--trace-deprecation: lint, typecheck, build, validate (742, ΔE 0.5439), sync-theme-count:check, test:coverage (417), lint:md, format:check, verify:package, site astro check / build / 110 tests / a11y 15. Zero deprecation warnings.data/unchanged after the Node 24 buildpnpm teston Node 22.22.3 and 26.5.0: 417/417 eachnpm_config_allow_scripts=nexus-agents pnpm verify:package: failed withEALLOWSCRIPTSbefore, now passes under npm 12.0.2 and Node 24's npm 11.19.0release.ymlruns only on a release, so its first real exercise will be the next publish🤖 Generated with Claude Code