Skip to content

chore: move the toolchain to Node 24 LTS and test on 22/24/26 - #318

Merged
williamzujkowski merged 1 commit into
mainfrom
chore/node-24-lts
Oct 3, 2026
Merged

williamzujkowski merged 1 commit into
mainfrom
chore/node-24-lts

Conversation

@williamzujkowski

Copy link
Copy Markdown
Owner

Summary

Third step of the LTS refresh: the toolchain and CI move to Node 24 (Active LTS), and CI also tests on 22 and 26. The decisions behind it:

  • Toolchain on 24, with 26 in the CI matrix. 26 becomes Active LTS on 2026-10-28, so the later switch is one line.
  • The published package keeps engines.node >=22 until Node 22's EOL (2027-04-30). This is not a breaking change for consumers.

The derived metrics were rounded first (#316), so moving the data build to Node 24 causes no dataset churn. That's verified below.

Changes

Area Change
Workflows node-version: 22 → 24 in ci, lighthouse, pages, update and release (×2)
CI test job Matrix [22, 24, 26], fail-fast: false. Branch protection requires only CI Success, which already gates on needs.test.
release.yml Removed npm install --global [email protected]. Node 24 bundles npm 11.19, which supports trusted publishing (≥ 11.5.1). Fetching a package manager in the job that holds the OIDC token was the risk the old comment described, and it was the Scorecard finding dismissed earlier. A small assertion now fails the job if the bundled npm is ever < 11.5.1.
scripts/verify-package.ts Strips npm_config_allow_scripts from child processes. npm 11.16–11.19 (Node 24's) and 12.0.x leak a user .npmrc allow-scripts into nested installs, which then fail with EALLOWSCRIPTS (npm/cli#9912, fixed in 11.20.0 / 12.1.0). This is the --allow-scripts error seen locally.
@types/node ^22 → ^24.19.0, locked at 24.19.0 (24.19.1 is inside the 7-day cooldown). Dependabot comment updated.
.nvmrc 24, for local dev
Docs AGENTS / CONTRIBUTING / CODING_STANDARDS: Node 24, TS 6.0 (7 blocked), Vitest 5 / vite 8, ESLint 10. The runtime-deps rule now includes zod, which has been a production dependency since v0.1.0 (the public API exports the schemas) but was missing from the docs.

Not changed, and why

Test plan

  • Node 24.21.0 with --trace-deprecation: lint, typecheck, build, validate (742, ΔE 0.5439), sync-theme-count:check, test:coverage (417), lint:md, format:check, verify:package, site astro check / build / 110 tests / a11y 15. Zero deprecation warnings.
  • data/ unchanged after the Node 24 build
  • pnpm test on Node 22.22.3 and 26.5.0: 417/417 each
  • npm_config_allow_scripts=nexus-agents pnpm verify:package: failed with EALLOWSCRIPTS before, now passes under npm 12.0.2 and Node 24's npm 11.19.0
  • npm-version assertion checked at the boundaries (11.5.0 ✗, 11.5.1 ✓, 11.19.0 ✓, 12.2.0 ✓, 10.9.9 ✗)
  • release.yml runs only on a release, so its first real exercise will be the next publish

🤖 Generated with Claude Code

Node 24 is the Active LTS; 22 is in maintenance (EOL 2027-04-30) and
26 becomes Active LTS on 2026-10-28.

- Workflows: node-version 22 -> 24 (ci, lighthouse, pages, update,
  release). The CI test job becomes a 22/24/26 matrix: 22 because the
  published package keeps engines.node >=22, 26 so the next switch is
  one line. Branch protection only requires "CI Success".
- release.yml: drop `npm install -g [email protected]`. Node 24 bundles npm
  11.19, which supports trusted publishing (>= 11.5.1); installing a
  package manager in the job holding the OIDC token was the risk the
  old comment described. An assertion now fails the job if the
  bundled npm is ever too old.
- verify-package: strip npm_config_allow_scripts from child processes.
  npm 11.16-11.19 (Node 24's) and 12.0.x leak a user .npmrc
  allow-scripts into nested installs, which then fail with
  EALLOWSCRIPTS (npm/cli#9912).
- @types/node ^22 -> ^24.19.0 (locked at 24.19.0; 24.19.1 is inside
  the 7-day cooldown). Dependabot comment updated.
- .nvmrc (24) for local dev; AGENTS/CONTRIBUTING/CODING_STANDARDS stack
  versions refreshed (Node 24, TS 6.0, Vitest 5, vite 8, ESLint 10)
  and the runtime-dependency list corrected to include zod.

engines.node stays >=22 for consumers.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@williamzujkowski
williamzujkowski enabled auto-merge (squash) October 3, 2026 18:29
@github-actions github-actions Bot added the chore Maintenance label Oct 3, 2026
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​types/​node@​22.20.4 ⏵ 24.19.010010081 +196100

View full report

@williamzujkowski
williamzujkowski merged commit d642942 into main Oct 3, 2026
21 checks passed
@williamzujkowski
williamzujkowski deleted the chore/node-24-lts branch October 3, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant