Repository navigation
Commit c8db549
docs(fix-2530): enhance close() method docstring with Python 3.13 guidance
Improve the SqlCatalog.close() docstring to:
- Emphasize that close() must be called in test fixture teardowns
- Explain Python 3.13+ ResourceWarning prevention
- Document the SQLAlchemy connection pool lifecycle
- Clarify importance for both test and production scenarios (blobfuse)
- Add reference to issue apache#2530
This helps future contributors understand why proper connection cleanup is essential.
Co-Authored-By: Claude Haiku 4.5 <[email protected]>1 parent 7281f05 commit c8db549
1 file changed
Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
778 | 778 | | |
779 | 779 | | |
780 | 780 | | |
781 | | - | |
782 | | - | |
783 | | - | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
784 | 792 | | |
785 | 793 | | |
786 | 794 | | |
0 commit comments