Import: Fix php warning when importing with variable name #75
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test plan suggestion:
|
Krinkle
force-pushed
the
fix-var-import-warning
branch
from
01fb53d to
2d45722
Compare
AaronSchulz
suggested changes
Nov 24, 2021
AaronSchulz
left a comment
AaronSchulz
left a comment
There was a problem hiding this comment.
Grammar error at "with have" in commit summary
The import worked fine, but it produced a warning as side-effect. Prevent this by recognising that some URL nodes assigned to $path during the first phase have $value set to a Variable node (instead of an Anonymous node), and thus don't have a value property themselves yet. Fixes wikimedia#29. Fixes wikimedia#32.
Krinkle
force-pushed
the
fix-var-import-warning
branch
from
2d45722 to
bd0b8dd
Compare
AaronSchulz
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import worked fine, but it produced a warning as side-effect.
Prevent this by recognising that some URL nodes assigned to $path during the first phase have $value set to a Variable node (instead of an Anonymous node), and thus don't have a value property themselves yet.
Fixes #29.
Fixes #32.