Don't attempt to pass URLs to file_exists() #68
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
See also:
In short, I worry that this would open up evaluation of external resources if mis-configured. However, I think I see something I previously missed - there is a point in the code earlier in the stack, in the Import constructor where we should treat these URLs as "literal CSS imports" much earlier so that they never end up in the parse code path in the first place. |
Krinkle
pushed a commit
that referenced
this pull request
Aug 10, 2021
The regex that was meant to handle this already accounted for a lot of edge cases, such as `/css` endpoints without `.css`, and query parameters like `/css?foo` or `/css;foo`, all to carefully avoid matching things like `foocss.less` or `foo.css.bar.less`. However can still be any number of CSS resources served from URLs that don't match that pattern. Instead of trying to match the path segment, just match the start of the URL, which should take care of any edge cases, given that we don't allow importing remote Less code for compilation anyway. Fixes #27. Closes #28. Closes #68.
Krinkle
added a commit
that referenced
this pull request
Aug 10, 2021
…73) The regex that was meant to handle this already accounted for a lot of edge cases, such as `/css` endpoints without `.css`, and query parameters like `/css?foo` or `/css;foo`, all to carefully avoid matching things like `foocss.less` or `foo.css.bar.less`. However can still be any number of CSS resources served from URLs that don't match that pattern. Instead of trying to match the path segment, just match the start of the URL, which should take care of any edge cases, given that we don't allow importing remote Less code for compilation anyway. Fixes #27. Closes #28. Closes #68. Co-authored-by: Max Semenik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file_exists() will return false for a file on a remote server.
This method could need a rewrite to handle URLs e.g. Google Fonts.