Fix open_basedir issues #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Here's the failure that's fixed by 383db69 |
mlocati
force-pushed
the
open_basedir
branch
from
abc8358 to
383db69
Compare
Krinkle
reviewed
Sep 30, 2019
Krinkle
reviewed
Mar 19, 2020
| return true; | ||
| } | ||
| $path = str_replace(DIRECTORY_SEPARATOR, '/', $path); | ||
| if ($path[0] === '/') { |
Member
There was a problem hiding this comment.
I suspect it would be more optimal to skip the str_replace and instead have:
if ( $path === DIRECTORY_SEPARATOR || $path[0] === '/' )
Below the preg_match would then be %^[a-z]:\\%i instead of %^[a-z]:/%i. Depending on whether supportingA:/ on Windows makes sense.
Member
|
I'm currently uncomfortable merging this as-is as I'd like to better understand what This change as-is would make that possible. There is #27 and #28, which would be best resolved first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's assume that:
@importmarked as(optional), with a relative path starting with../In that case, the library tries to look for the existence of that non existing path starting from the current directory.
This is an issue because:
In this pull request, I start adding a test that shows this issue (that is, the TravisCI jobs should fail).
I'll add another commit once the TravisCI jobs complete.