Skip to content

ci: fix and re-enable memoryleak test#936

Merged
maartenbreddels merged 1 commit intomasterfrom
12-17-ci_fix_and_re-enable_memoryleak_test
Dec 19, 2024
Merged

ci: fix and re-enable memoryleak test#936
maartenbreddels merged 1 commit intomasterfrom
12-17-ci_fix_and_re-enable_memoryleak_test

Conversation

@iisakkirotko
Copy link
Copy Markdown
Collaborator

@iisakkirotko iisakkirotko commented Dec 17, 2024

All Submissions:

Changes to / New Features:

Description of changes

Fix final issues with memory leaks test:

  • There were sometimes (in flask) references to kernel contexts from dummythreads
  • The RuntimeError we raised when attempting to close an already closed kernel context would keep a stack with reference to the context
  • Playwright's trace would also keep references to some of the tracked objects at times

Copy link
Copy Markdown
Collaborator Author

iisakkirotko commented Dec 17, 2024

@iisakkirotko iisakkirotko force-pushed the 12-17-ci_fix_and_re-enable_memoryleak_test branch from 9d85bc7 to 3f769b5 Compare December 17, 2024 16:08
@iisakkirotko iisakkirotko changed the base branch from 11-13-fix_test_and_avoid_memory_leaks_by_checking_references_to_virtual_kernel to master December 17, 2024 16:08
@iisakkirotko iisakkirotko marked this pull request as ready for review December 17, 2024 16:09
@iisakkirotko iisakkirotko force-pushed the 12-17-ci_fix_and_re-enable_memoryleak_test branch from 3f769b5 to 994afc4 Compare December 17, 2024 16:10
@iisakkirotko iisakkirotko force-pushed the 12-17-ci_fix_and_re-enable_memoryleak_test branch from 994afc4 to ff0c44c Compare December 17, 2024 16:10
@maartenbreddels maartenbreddels merged commit a5b0dde into master Dec 19, 2024
@maartenbreddels
Copy link
Copy Markdown
Contributor

Awesome and impressive work! I spend/wasted a lot of time getting this working, and failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants