fix: inputdate not allowing format changes after creation#933
Merged
iisakkirotko merged 2 commits intomasterfrom Dec 19, 2024
Merged
Conversation
maartenbreddels
temporarily deployed
to
12-16-fix_inputdate_not_allowing_format_changes_after_creation - solara-stable PR #933
Render
Destroyed
iisakkirotko
force-pushed
the
12-16-fix_inputdate_not_allowing_format_changes_after_creation
branch
from
e50a4fc to
d971259
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
pre-commitprior to committing my changes (see development setup docs).Description of changes
Previously, as seen in https://py.cafe/iisakkirotko/solara-date-format-changer,
InputDatewould not respectdate_formatchanges after the component was created. This would mean that if the format was changed, any input through the picker would be labeled invalid. Also fixes the same issue forInputTime(NOTE: Requires #654 to be merged in order to merge correctly. Graphite didn't like the fact that #654 comes from another repo)Fixes #932