feat: do not allow reactive to be used as boolean#846
Merged
maartenbreddels merged 2 commits intomasterfrom Dec 17, 2024
Merged
feat: do not allow reactive to be used as boolean#846maartenbreddels merged 2 commits intomasterfrom
maartenbreddels merged 2 commits intomasterfrom
Conversation
maartenbreddels
changed the title
Contributor
Author
|
@Jhsmit i guess you would like this |
Contributor
|
see also #782 |
iisakkirotko
force-pushed
the
feat_disable_boolean_use_of_reactives
branch
from
80b51ae to
f9cb94a
Compare
Collaborator
This stack of pull requests is managed by Graphite. Learn more about stacking. |
maartenbreddels
commented
Dec 13, 2024
iisakkirotko
force-pushed
the
feat_disable_boolean_use_of_reactives
branch
from
f9cb94a to
dd20225
Compare
iisakkirotko
force-pushed
the
feat_disable_boolean_use_of_reactives
branch
from
dd20225 to
5240c2d
Compare
Contributor
Author
|
Should we start adding a run of the unittests with this setting on? Can be a 2nd commit on this branch. |
7 tasks
maartenbreddels
force-pushed
the
feat_disable_boolean_use_of_reactives
branch
from
aa1d0a2 to
e46fa72
Compare
reactive_var = solara.reactive(0) ... if reactive_var: # this is often a mistake if reactive_var.value: # this is the correct way to check the value
iisakkirotko
force-pushed
the
feat_disable_boolean_use_of_reactives
branch
from
e46fa72 to
2c75ff8
Compare
maartenbreddels
temporarily deployed
to
feat_disable_boolean_use_of_reactives - solara-stable PR #846
Render
Destroyed
Contributor
Author
|
Note: this feature is not enabled by default in solara 1.x, it will be planned to be the default in 2.x and above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.