Skip to content

feat: enable navigation to hashes#814

Merged
iisakkirotko merged 2 commits intomasterfrom
10-14-feat_enable_navigation_to_hashes
Oct 24, 2024
Merged

feat: enable navigation to hashes#814
iisakkirotko merged 2 commits intomasterfrom
10-14-feat_enable_navigation_to_hashes

Conversation

@iisakkirotko
Copy link
Copy Markdown
Collaborator

@iisakkirotko iisakkirotko commented Oct 14, 2024

Previously this was not officially supported, and would only work when moving within a page, or when initially loading a page with SSG enabled.

@iisakkirotko Graphite App
Copy link
Copy Markdown
Collaborator Author

iisakkirotko commented Oct 14, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iisakkirotko and the rest of your teammates on Graphite Graphite

This was referenced Oct 14, 2024
Merged
Merged
@iisakkirotko iisakkirotko force-pushed the 10-14-feat_enable_navigation_to_hashes branch from 63b998e to 172f50c Compare October 14, 2024 15:01
maartenbreddels
maartenbreddels reviewed Oct 15, 2024
View reviewed changes
@maartenbreddels
Copy link
Copy Markdown
Contributor

maartenbreddels commented Oct 22, 2024

If I go:
http://localhost:8765/documentation/advanced/enterprise/oauth
and click on say 'Configuring Fief' i navigate to it, but the hash does not change in the address bar (80% of the time).
If I then click it again, the hash does change.
I scroll up a bit, and click the https link with the hash to
http://localhost:8765/documentation/getting_started/deploying/self-hosted#https
That works seems to work, as well as navigating back, but it might be good to check after fixes.
I wonder if the problem is related to having 2 state attributes?

@iisakkirotko iisakkirotko force-pushed the 10-14-chore_remove_extra_checks_for_hash branch from 541b4bc to 916e8cf Compare October 22, 2024 15:13
@iisakkirotko iisakkirotko force-pushed the 10-14-feat_enable_navigation_to_hashes branch from 172f50c to 53b21e8 Compare October 22, 2024 15:13
@iisakkirotko Graphite App
Copy link
Copy Markdown
Collaborator Author

iisakkirotko commented Oct 24, 2024 •
edited
Loading

Merge activity

  • Oct 24, 11:04 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 24, 11:07 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 24, 11:08 AM EDT: A user merged this pull request with Graphite.

@iisakkirotko iisakkirotko changed the base branch from 10-14-chore_remove_extra_checks_for_hash to graphite-base/814 October 24, 2024 15:05
@iisakkirotko iisakkirotko changed the base branch from graphite-base/814 to master October 24, 2024 15:05
@iisakkirotko
feat: enable navigation to hashes
c67cde0 
Previously this was not officially supported, and would only work when moving within a page, or when initially loading a page with SSG enabled.
@iisakkirotko
fix: outdated anchor would sometimes be shown
105c87f
@iisakkirotko iisakkirotko force-pushed the 10-14-feat_enable_navigation_to_hashes branch from 53b21e8 to 105c87f Compare October 24, 2024 15:06
@iisakkirotko iisakkirotko merged commit ab09c58 into master Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maartenbreddels maartenbreddels maartenbreddels left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iisakkirotko @maartenbreddels