chore: remove unnecessary checks for location hashes#813
Conversation
maartenbreddels
temporarily deployed
to
10-14-chore_remove_extra_checks_for_hash - solara-stable PR #813
Render
Destroyed
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @iisakkirotko and the rest of your teammates on |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @iisakkirotko and the rest of your teammates on |
1 similar comment
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @iisakkirotko and the rest of your teammates on |
| // take of the anchor | ||
| if (location.indexOf("#") !== -1) { | ||
| location = location.slice(0, location.indexOf("#")); | ||
| } |
There was a problem hiding this comment.
But if you do a hard page navigation with an anchor in it, this will include a hash right?
There was a problem hiding this comment.
Ah, no, when I look at the anatomy: https://developer.mozilla.org/en-US/docs/Web/API/Location I see it does not include it
Hash is never included in `window.location.pathname`
iisakkirotko
force-pushed
the
10-14-chore_remove_extra_checks_for_hash
branch
from
541b4bc to
916e8cf
Compare
2 participants
Hash is never included in
window.location.pathname