fix: app hangs on starlette when sufficiently many cookies are set#751
Merged
maartenbreddels merged 2 commits intomasterfrom Aug 26, 2024
Merged
Conversation
Collaborator
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @iisakkirotko and the rest of your teammates on |
Contributor
I added branch protection so we can auto merge, but that didn't let us do the auto commit. I had to disable it, so the updates ran on master. Maybe that was the same issue? @EwoutH could you try to open a new trivial PR so we can test this? |
In version 13.0 of `websockets`, the environmental variables to configure websockets were renamed (see [here](https://websockets.readthedocs.io/en/stable/project/changelog.html#id2)), which caused apps to hang when running on starlette with more than 8kb of cookies set.
iisakkirotko
force-pushed
the
08-26-ci_automatic_testing_suite_failing
branch
from
36a9641 to
165841b
Compare
iisakkirotko
changed the title
Contributor
Of course, but I now see CI passing, so is it still needed? Edit: If so, what do I need to do exactly? |
Collaborator
Author
Contributor
|
Thanks @iisakkirotko ! Sorry, I misunderstoof @EwoutH , it seems 3 (!) related issues were confused in my mind |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couldn't reproduce locally. Giving ci a shot.