fix: to redirect back after auth we used the wrong base url#747
Merged
maartenbreddels merged 1 commit intomasterfrom Aug 23, 2024
Merged
Conversation
settings.main.base_url should have been used, since that can be used to override the base url from starlette. Note that this should always never be needed once a proxy and uvicorn are configured correctly (see also #745). But starlette does not respect the x-forwarded-host header, so we might need to use this in the future in situations of proxies that need to set the Host header due to https communication. Fixes #740
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
settings.main.base_url should have been used, since that can be used to override the base url from starlette.
Note that this should always never be needed once a proxy and uvicorn are configured correctly (see also #745).
But starlette does not respect the x-forwarded-host header, so we might need to use this in the future in situations of proxies that need to set the Host header due to https communication.
Fixes #740