ci: enable windows integration tests#739
Merged
maartenbreddels merged 10 commits intomasterfrom Aug 23, 2024
Merged
Conversation
We used os.path.sep, which is \ on windows. Fixes #722
maartenbreddels
force-pushed
the
ci_enable_windows_integration_tests
branch
from
687f3b6 to
b33984d
Compare
maartenbreddels
force-pushed
the
ci_enable_windows_integration_tests
branch
2 times, most recently
from
3773e3f to
5409683
Compare
Sometimes (on CI) the pathnames have different casing, and then the path checking fails.
maartenbreddels
force-pushed
the
ci_enable_windows_integration_tests
branch
from
5409683 to
1b635f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled in f8c5242 which was needed because we never ran them because of a mistake in our yaml file which was fixed in cf52a3d