fix: fetch javascript assets correcly when SOLARA_ASSETS_PROXY=False#705
Merged
maartenbreddels merged 1 commit intomasterfrom Jul 4, 2024
Merged
fix: fetch javascript assets correcly when SOLARA_ASSETS_PROXY=False#705maartenbreddels merged 1 commit intomasterfrom
maartenbreddels merged 1 commit intomasterfrom
Conversation
We did not set what was previously named `solara_cdn`. That caused vue template to not use the right cdn when we did not proxy. This also simplied the login, and motivated a rename of getBaseUrl -> getJupyterBaseUrl since that is only used in Jupyter notebook, Lab and Voila.
maartenbreddels
force-pushed
the
fix_cdn_proxy_false
branch
from
95fdbd3 to
3bc00db
Compare
maartenbreddels
added a commit
that referenced
this pull request
Jul 10, 2024
We missed this component.
maartenbreddels
added a commit
that referenced
this pull request
Jul 10, 2024
We missed this component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did not set what was previously named
solara_cdn. That caused vue template to not use the right cdn when we did not proxy. This also simplied the login, and motivated a rename of getBaseUrl -> getJupyterBaseUrl since that is only used in Jupyter notebook, Lab and Voila.