fix: if we hit a 404 in starlette, raise instead of render a 404#670
Merged
maartenbreddels merged 1 commit intomasterfrom Jun 25, 2024
Merged
Conversation
This allows middleware or error handlers to catch the 404 and do
something custom.
Example:
```
import solara
clicks = solara.reactive(0)
added = False
def add_exception_handler():
global added
print("add_exception_handler", added)
if not added:
import solara.server.starlette
from starlette.responses import HTMLResponse
async def server_error(request, exc):
return HTMLResponse(content="My custom 404", status_code=exc.status_code)
solara.server.starlette.app.add_exception_handler(404, server_error)
added = True
@solara.component
def Page():
add_exception_handler()
solara.Text("hello world")
```
iisakkirotko
approved these changes
Jun 25, 2024
Collaborator
iisakkirotko
left a comment
There was a problem hiding this comment.
Looks great! Should be super useful for everyone using Solara, including us :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows middleware or error handlers to catch the 404 and do something custom.
Example: