fix: support esm define when running under virtual kernel#668
Merged
maartenbreddels merged 1 commit intomasterfrom Jun 6, 2024
Merged
fix: support esm define when running under virtual kernel#668maartenbreddels merged 1 commit intomasterfrom
maartenbreddels merged 1 commit intomasterfrom
Conversation
maartenbreddels
force-pushed
the
fix_esm_define_in_kernel
branch
from
02b9bf0 to
0b9e0b6
Compare
When we define a esm top level in a module, we don't need to create the module widget. However, if we do this during the running of the app under the context of a virtual kernel, we should directly create the esm widget. Should fix the failing of widgetti/ipyantd#4
maartenbreddels
force-pushed
the
fix_esm_define_in_kernel
branch
from
0b9e0b6 to
47a8b6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we define a esm top level in a module, we don't need to create the module widget. However, if we do this during the running of the app under the context of a virtual kernel, we should directly create the esm widget.
Should fix the failing of widgetti/ipyantd#4