fix!: solara.Meta elements insert empty span into DOM by iisakkirotko · Pull Request #625 · widgetti/solara

iisakkirotko · 2024-04-30T14:49:31Z

The insertion of <span></span> into the dom is what causes strange extra spacing at the top of notebook-based tutorials with solara.Meta tags currently:

Fixes #626

TODO:

Revert change to jupyter dashboard tutorial page

iisakkirotko · 2024-04-30T14:49:42Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

fix!: solara.Meta elements insert empty span into DOM #625 👈 (View in Graphite)
feat!: Solara 2.0 #946 : 9 other dependent PRs (#657 , #947 , #948 and 6 others)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

mariobuikhuizen · 2024-05-01T09:37:00Z

Why is this a problem? Why is the span even needed?

iisakkirotko · 2024-05-01T09:42:56Z

@mariobuikhuizen This is what causes the extra spacing at the top of notebook-based tutorials with solara.Meta tags currently:

Granted this happens because these spans get inserted into a flex-box with some gaps defined, so not using that could be an alternative solution. The spans seem to be necessary because Vue does not like empty templates, those throw two errors saying:

[Vue warn]: Error compiling template:
Cannot use <template> as component root element because it may contain multiple nodes.

and

[Vue warn]: Error compiling template:
Templates should only be responsible for mapping the state to the UI. Avoid placing tags with side-effects in your templates, such as <script>, as they will not be parsed.

mariobuikhuizen · 2024-05-01T09:53:48Z

@mariobuikhuizen This is what causes the extra spacing at the top of notebook-based tutorials with solara.Meta tags

This would be a better title for the commit/PR.

The spans seem to be necessary because Vue does not like empty templates, those throw two errors

Strange, I never noticed an error with an empty template.

mariobuikhuizen · 2024-05-01T10:32:14Z

Ok, I checked it, I write empty templates like this:

<template>
</template>

This produces no errors.

Doing it like this:

<template></template>

Does produce the second error you mentioned.

mariobuikhuizen · 2024-05-01T11:09:48Z

It's a bug in ipyvue that empty template tags on the same line don't work.

iisakkirotko · 2024-05-01T11:14:16Z

Putting the templates on two different lines fixes both errors. What are your thoughts on the PR? In principle this is a breaking change on the UI side (if someone was unknowingly relying on this for spacing, for example), but I think we can sell it as a fix. I could rename it as suggested, but then the scope of the change seems smaller than it might be.

Having an empty template on one line or no tempate tag at all would incorrectly fallback to the deprecated template format where template tags were ommited. See: spacetelescope/jdaviz#2668 and widgetti/solara#625

Reverts #627, since the workaround is no longer needed.

…OM (#625) * fix[docs]: solara.Meta elements insert empty span into DOM * chore: remove workaround from jupyter notebook tutorial Reverts #627, since the workaround is no longer needed. * fix!: navigator would insert an empty span into dom

iisakkirotko mentioned this pull request Apr 30, 2024

fix[docs]: wide outputs of jupyter notebook based tutorials overflowing width limit" #624

Merged

iisakkirotko force-pushed the 04-30-fix_docs_wide_outputs_of_jupyter_notebook_based_tutorials_overflowing_width_limit_ branch from e500a9b to 103e0af Compare May 1, 2024 11:06

iisakkirotko force-pushed the 04-30-fix_docs_solara.meta_elements_insert_empty_span_into_dom branch from bc6dd96 to 432d4b6 Compare May 1, 2024 11:06

iisakkirotko added this to the Solara 2.0 milestone May 1, 2024

iisakkirotko force-pushed the 04-30-fix_docs_solara.meta_elements_insert_empty_span_into_dom branch from 432d4b6 to ffbdeff Compare May 1, 2024 12:09

iisakkirotko changed the base branch from 04-30-fix_docs_wide_outputs_of_jupyter_notebook_based_tutorials_overflowing_width_limit_ to master May 1, 2024 12:09

iisakkirotko mentioned this pull request May 1, 2024

fix[docs]: remove extra space from top of jupyter dashboard tutorial #627

Merged

mariobuikhuizen mentioned this pull request May 1, 2024

fix: empty template on one line or no template tag causes error widgetti/ipyvue#92

Merged

iisakkirotko force-pushed the master branch from bc882df to 5bf2d37 Compare May 6, 2024 09:29

iisakkirotko changed the title ~~fix[docs]: solara.Meta elements insert empty span into DOM~~ fix: solara.Meta elements insert empty span into DOM Jul 4, 2024

iisakkirotko changed the title ~~fix: solara.Meta elements insert empty span into DOM~~ fix!: solara.Meta elements insert empty span into DOM Jul 4, 2024

maartenbreddels force-pushed the master branch 2 times, most recently from 86646f5 to df2fd66 Compare July 11, 2024 15:41

maartenbreddels force-pushed the master branch 2 times, most recently from cded5b2 to 32af76f Compare December 20, 2024 12:52

fix[docs]: solara.Meta elements insert empty span into DOM

98f59f9

iisakkirotko force-pushed the 04-30-fix_docs_solara.meta_elements_insert_empty_span_into_dom branch from ffbdeff to 98f59f9 Compare December 23, 2024 09:14

iisakkirotko changed the base branch from master to 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults December 23, 2024 09:14

This was referenced Dec 23, 2024

feat!: Solara 2.0 #946

Draft

refactor!: streamline and improve applayout api #657

Open

fix!: unexpected margins on widgets #947

Merged

iisakkirotko mentioned this pull request Dec 23, 2024

fix: widget-box would hide overflowing content #948

Merged

4 tasks

iisakkirotko added 2 commits December 23, 2024 11:43

chore: remove workaround from jupyter notebook tutorial

2a9d40e

Reverts #627, since the workaround is no longer needed.

fix!: navigator would insert an empty span into dom

463602c

iisakkirotko mentioned this pull request Dec 23, 2024

feat: deprecate use_thread #949

Merged

5 tasks

iisakkirotko merged commit 3a90256 into 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults Dec 23, 2024

iisakkirotko mentioned this pull request Dec 23, 2024

chore: explicitly re-export components #951

Merged

4 tasks

iisakkirotko mentioned this pull request Dec 27, 2024

chore: move confirmationDialog and Menu out of lab #955

Merged

4 tasks

This was referenced Jan 20, 2025

fix!: use Mario's vuetify #977

Closed

refactor!: use origin instead of base_url in configuration #979

Open

iisakkirotko mentioned this pull request Jan 23, 2025

feat: allow disabling mutation detection per reactive instance #984

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix!: solara.Meta elements insert empty span into DOM#625

fix!: solara.Meta elements insert empty span into DOM#625
iisakkirotko merged 3 commits into12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaultsfrom
04-30-fix_docs_solara.meta_elements_insert_empty_span_into_dom

iisakkirotko commented Apr 30, 2024 •

edited

Loading

Uh oh!

iisakkirotko commented Apr 30, 2024 •

edited

Loading

Uh oh!

mariobuikhuizen commented May 1, 2024

Uh oh!

iisakkirotko commented May 1, 2024

Uh oh!

mariobuikhuizen commented May 1, 2024

Uh oh!

mariobuikhuizen commented May 1, 2024

Uh oh!

mariobuikhuizen commented May 1, 2024 •

edited

Loading

Uh oh!

iisakkirotko commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

iisakkirotko commented Apr 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iisakkirotko commented Apr 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mariobuikhuizen commented May 1, 2024

Uh oh!

iisakkirotko commented May 1, 2024

Uh oh!

mariobuikhuizen commented May 1, 2024

Uh oh!

mariobuikhuizen commented May 1, 2024

Uh oh!

mariobuikhuizen commented May 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iisakkirotko commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

iisakkirotko commented Apr 30, 2024 •

edited

Loading

iisakkirotko commented Apr 30, 2024 •

edited

Loading

mariobuikhuizen commented May 1, 2024 •

edited

Loading