fix: more unique keys for tasks to reduce mixup during hot reloads#609
Merged
maartenbreddels merged 1 commit intomasterfrom Apr 22, 2024
Merged
fix: more unique keys for tasks to reduce mixup during hot reloads#609maartenbreddels merged 1 commit intomasterfrom
maartenbreddels merged 1 commit intomasterfrom
Conversation
When used in use_task, this can create many keys, which after a next render can be mixed up with a global task. Now the key include the function name, so it is more unique.
maartenbreddels
force-pushed
the
fix_more_unique_keys_for_tasks
branch
from
eb07c53 to
c761c8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When used in use_task, this can create many keys, which after a next render can be mixed up with a global task.
Now the key include the function name, so it is more unique.