fix: fade out was not restored on navigations from a thread or task#594
Merged
maartenbreddels merged 1 commit intomasterfrom Apr 12, 2024
Merged
Conversation
maartenbreddels
changed the title
A busy/idle pair of messages is only send when around a websocket message is handled in the main solara-server task. When the browser location changes, we fade out the main content, which we restore again when the idle message is received. But if we change the location from a thread or task, the busy and idle messages are not send, so the fade out is not restored, leaving the main content faded out. To solve this we only fade out when the location changes and the kernel is busy.
maartenbreddels
force-pushed
the
fix_no_fade_restore_on_navigation
branch
from
9a50116 to
6f48654
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A busy/idle pair of messages is only send when around a websocket message is handled in the main solara-server task.
When the browser location changes, we fade out the main content, which we restore again when the idle message is received. But if we change the location from a thread or task, the busy and idle messages are not send, so the fade out is not restored, leaving the main content faded out.
To solve this we only fade out when the location changes and the kernel is busy.