fix: nested vuetify apps should not have 100vh#570
Merged
maartenbreddels merged 1 commit intomasterfrom Mar 25, 2024
Merged
Conversation
maartenbreddels
force-pushed
the
fix_nested_vuetify_apps
branch
from
6d8d234 to
eaa8f3c
Compare
If a vue tree gets interrupted (by ipyreact or classic ipywidgets) we start a new (vuetify) app. This causes that root DOM element to take up 100vh, which is only needed for the top-level app.
maartenbreddels
force-pushed
the
fix_nested_vuetify_apps
branch
from
eaa8f3c to
9547381
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a vue tree gets interrupted (by ipyreact or classic ipywidgets) we start a new (vuetify) app. This causes that root DOM element to take up 100vh, which is only needed for the top-level app.