fix: do no parse -- and subsequent arguments on the command line#558
Merged
maartenbreddels merged 1 commit intomasterfrom Mar 18, 2024
Conversation
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maartenbreddels and the rest of your teammates on |
|
I just tested it and it works great! |
This allows a user to pass custom args that can be parsed in the application. click does not seem to support this: pallets/click#619 But it is easy to work around by passing the args ourselves after removing the -- and subsequent args.
94de306 to
5bab385
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This allows a user to pass custom args that can be parsed in the
application.
click does not seem to support this:
pallets/click#619
But it is easy to work around by passing the args ourselves after
removing the -- and subsequent args.