Skip to content

fix: support Layout when specifying routes#554

Merged
maartenbreddels merged 1 commit intomasterfrom
03-13-fix_layout_when_using_routes
Mar 19, 2024
Merged

fix: support Layout when specifying routes#554
maartenbreddels merged 1 commit intomasterfrom
03-13-fix_layout_when_using_routes

Conversation

@maartenbreddels
Copy link
Copy Markdown
Contributor

@maartenbreddels maartenbreddels commented Mar 13, 2024

Before, if we specified

routes = [
    solara.Route(path="/", component=Home, label="Home", layout=Layout),
    solara.Route(path="about", component=About, label="About"),
]

We would not render the the page and layout correcly.

@maartenbreddels Graphite App
Copy link
Copy Markdown
Contributor Author

maartenbreddels commented Mar 13, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maartenbreddels and the rest of your teammates on Graphite Graphite

@maartenbreddels maartenbreddels force-pushed the 03-13-fix_layout_when_using_routes branch from 0b25590 to e3a2107 Compare March 13, 2024 15:55
@maartenbreddels maartenbreddels mentioned this pull request Mar 13, 2024
Merged
@maartenbreddels maartenbreddels force-pushed the 03-13-fix_layout_when_using_routes branch from e3a2107 to df40333 Compare March 19, 2024 14:26
@maartenbreddels Graphite App
Copy link
Copy Markdown
Contributor Author

maartenbreddels commented Mar 19, 2024 •
edited
Loading

Merge activity

@maartenbreddels maartenbreddels merged commit 4d17086 into master Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@maartenbreddels