chore: update javascript package dependencies#484
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @iisakkirotko and the rest of your teammates on |
1a589d6 to
268dbf0
Compare
268dbf0 to
b56de82
Compare
dea0811 to
6fe38f7
Compare
b56de82 to
e641658
Compare
6fe38f7 to
d8d9409
Compare
d8d9409 to
59b3f21
Compare
8d6d259 to
068665d
Compare
maartenbreddels
left a comment
There was a problem hiding this comment.
just a few changes (i don't think you can accept them, you need to run npm install to also update the lockfile)
|
There is still an vuetify version bump, you can remove that and update the lockfile please? |
Apparently there is, yeah... The new version matches https://github.com/widgetti/ipyvuetify/blob/7729f015ad384ab1549b25dc21175d3b7f246452/js/package.json#L64, though. Should I change it to what it was instead of that? |
|
That's the vue3/vuetify3 branch: https://github.com/widgetti/ipyvuetify/blob/vuetify3/js/package.json#L64 for vuetify 2 we use mario's branch |
aeb8952 to
b51bcfc
Compare
|
@maartenbreddels So then all Vuetify versions match, correct? (I also did run Also, if we want to keep our Vuetify versions in sync with ipyvuetify, perhaps we should hard fix them in both, instead of using the compatible with |
b51bcfc to
5bbd2ae
Compare
requested changes have been implemented, as agreed in separate discussion
5bbd2ae to
a85771d
Compare
a85771d to
51f0883
Compare

First commit is just bumping nodejs 14 -> 20 to check if build gets the same error as my local machine :)