fix: do not use excessive memory when rendering markdown#382
Merged
maartenbreddels merged 1 commit intomasterfrom Nov 15, 2023
Merged
Conversation
Due to legacy reasons we enabled the emoji plugin from pymdown. Every time the Markdown object gets created, it will load the emoji extension and will deep copy the emoji database. This is about 150kb of data: len(str(pymdownx.emoji1_db.emoji)) This is not a lot, but it is unnecessary and can be avoided.
Contributor
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to legacy reasons we enabled the emoji plugin from pymdown.
Every time the Markdown object gets created, it will load the
emoji extension and will deep copy the emoji database.
This is about 150kb of data:
len(str(pymdownx.emoji1_db.emoji))
This is not a lot, but it is unnecessary and can be avoided.