fix: None value in ToggleButtons resulted in Button label value#369
Merged
maartenbreddels merged 1 commit intomasterfrom Nov 3, 2023
Conversation
Contributor
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
In the example below, before, we would get the value 'default'
instead of the value `None`.
```
import solara
@solara.component
def Page():
size = solara.use_reactive(None)
print("size", repr(size.value))
with solara.ToggleButtonsSingle(value=size, on_value=size.set):
solara.Button("x-small", value="x-small")
solara.Button("small", value="small")
solara.Button("default", value=None)
solara.Button("large", value="large")
solara.Button("x-large", value="x-large")
```
6cf1d7d to
6e9e2e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In the example below, before, we would get the value 'default'
instead of the value
None.