Skip to content

fix: None value in ToggleButtons resulted in Button label value#369

Merged
maartenbreddels merged 1 commit intomasterfrom
11-03-fix_None_value_in_ToggleButtons_resulted_in_Button_label_value
Nov 3, 2023
Merged

fix: None value in ToggleButtons resulted in Button label value#369
maartenbreddels merged 1 commit intomasterfrom
11-03-fix_None_value_in_ToggleButtons_resulted_in_Button_label_value

Conversation

@maartenbreddels
Copy link
Copy Markdown
Contributor

In the example below, before, we would get the value 'default'
instead of the value None.

import solara

@solara.component
def Page():
    size = solara.use_reactive(None)
    print("size", repr(size.value))

    with solara.ToggleButtonsSingle(value=size, on_value=size.set):
        solara.Button("x-small", value="x-small")
        solara.Button("small", value="small")
        solara.Button("default", value=None)
        solara.Button("large", value="large")
        solara.Button("x-large", value="x-large")

Copy link
Copy Markdown
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

In the example below, before, we would get the value 'default'
instead of the value `None`.
```
import solara

@solara.component
def Page():
    size = solara.use_reactive(None)
    print("size", repr(size.value))

    with solara.ToggleButtonsSingle(value=size, on_value=size.set):
        solara.Button("x-small", value="x-small")
        solara.Button("small", value="small")
        solara.Button("default", value=None)
        solara.Button("large", value="large")
        solara.Button("x-large", value="x-large")
```
@maartenbreddels maartenbreddels force-pushed the 11-03-fix_None_value_in_ToggleButtons_resulted_in_Button_label_value branch from 6cf1d7d to 6e9e2e3 Compare November 3, 2023 11:12
@maartenbreddels maartenbreddels merged commit 7503b44 into master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant