fix:Responsive support for echart#273
Merged
iisakkirotko merged 1 commit intowidgetti:masterfrom Dec 4, 2024
Merged
Conversation
maartenbreddels
requested changes
Sep 6, 2023
Contributor
maartenbreddels
left a comment
maartenbreddels
left a comment
There was a problem hiding this comment.
Hi,
thanks a lot for opening this PR!
I think it's okay that it does not have an explicit example.
I wonder if responsive should be the default, and why someone would want to disable it (@mariobuikhuizen what do you think).
There are a lot of unrelated changes to this PR, which I would like you to revert. I don't agree with the other changes and those may drag this PR on for a long time. I suggest you revert them and open new issues, or a PR for the other plans you have with this component. This way we can get this PR merged soon, and not get distracted by the other changes.
What do you think?
Regards,
Maarten
maartenbreddels
force-pushed
the
master
branch
4 times, most recently
from
2446983 to
0d6161d
Compare
iisakkirotko
force-pushed
the
master
branch
2 times, most recently
from
c2951b9 to
8816e36
Compare
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
240a079 to
b098da1
Compare
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
86646f5 to
df2fd66
Compare
iisakkirotko
force-pushed
the
fix_responsive_echarts
branch
from
4e7033c to
17583ca
Compare
maartenbreddels
approved these changes
Dec 3, 2024
Collaborator
|
Thanks a lot for the contribution @Sanuki-073! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responsive support in solara/component/echarts.py and solara/component/echarts.vue
GIF of the actual resiseable grid layout in action can be found in following issue.
#268