fix: support Starlette 1.0 by using lifespan instead of on_startup/on_shutdown#1151
Open
maartenbreddelsai wants to merge 1 commit intowidgetti:masterfrom
Open
fix: support Starlette 1.0 by using lifespan instead of on_startup/on_shutdown#1151maartenbreddelsai wants to merge 1 commit intowidgetti:masterfrom
maartenbreddelsai wants to merge 1 commit intowidgetti:masterfrom
Conversation
maartenbreddelsai
force-pushed
the
fix/starlette-1.0-lifespan
branch
from
6660785 to
8904774
Compare
… compatibility Starlette 1.0 removed the on_startup and on_shutdown parameters in favor of the lifespan context manager. This change migrates to using lifespan, which has been supported since Starlette 0.13.5. Fixes widgetti#1143
maartenbreddelsai
force-pushed
the
fix/starlette-1.0-lifespan
branch
from
8904774 to
5a7fde6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starlette 1.0 removed the
on_startupandon_shutdownparameters fromStarlette.__init__(). This causes Solara to crash on import with Starlette 1.0.Fixes #1143
Changes
lifespanasync context manager that wraps existingon_startup()andon_shutdown()functionslifespanparameter instead ofon_startup/on_shutdownThe
lifespanparameter has been supported since Starlette 0.13.5, so this change is backward compatible with all reasonably recent Starlette versions.Testing
Tested with both: