fix: allow calling async tasks from threaded tasks#1029
Merged
maartenbreddels merged 1 commit intomasterfrom Apr 14, 2025
Merged
fix: allow calling async tasks from threaded tasks#1029maartenbreddels merged 1 commit intomasterfrom
maartenbreddels merged 1 commit intomasterfrom
Conversation
maartenbreddels
force-pushed
the
fix_run_async_task_from_threaded
branch
from
8b887b4 to
0775ed0
Compare
maartenbreddels
force-pushed
the
fix_run_async_task_from_threaded
branch
from
0775ed0 to
9ae65ae
Compare
Instead of assuming an event loop to exist, we use the event loop of the main thread in solara server (the one that starlette created for the websocket). In the case of IPython/Jupyter, we use the main event loop.
maartenbreddels
force-pushed
the
fix_run_async_task_from_threaded
branch
from
9ae65ae to
304f10e
Compare
maartenbreddels
temporarily deployed
to
fix_run_async_task_from_threaded - solara-stable PR #1029
Render
Destroyed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of assuming an event loop to exist, we use the event loop of the main thread in solara server (the one that starlette created for the websocket).
In the case of IPython/Jupyter, we use the main event loop.