Skip to content

OAuth flow breaking due to wrong base url variable being used #740

@cyrfar

Description

@cyrfar

Hi, I was trying to test auth in a Solara app and noticed that somewhere along the way redirect urls get overwritten by a default values rather than use the SOLARA_BASE_URL that I set in my environment. I suspect maybe the redirect_uri being passed here

result = await oauth.oauth1.authorize_redirect(request, str(request.base_url) + "_solara/auth/authorize")

should be using settings.main.base_url (which correctly updates when I set SOLARA_BASE_URL) instead of request.base_url (which is based on default values).

In a more detailed discussion with @maartenbreddels in the Discord channel we suspect this to be a small bug and a fix could potentially resolve the issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions