fix: false positive for returns in async defs for hook use

maartenbreddels · maartenbreddels · commit 67381dc60049 · 2025-12-05T12:56:50.000+01:00
diff --git a/solara/validate_hooks.py b/solara/validate_hooks.py
@@ -31,11 +31,11 @@ class InvalidReactivityCause(Enum):
 
 
 if sys.version_info < (3, 11):
-    ScopeNodeType = t.Union[ast.For, ast.While, ast.If, ast.Try, ast.FunctionDef]
+    ScopeNodeType = t.Union[ast.For, ast.While, ast.If, ast.Try, ast.FunctionDef, ast.AsyncFunctionDef]
     TryNodes = (ast.Try,)
 else:
     # except* nodes are only standardized in 3.11+
-    ScopeNodeType = t.Union[ast.For, ast.While, ast.If, ast.Try, ast.TryStar, ast.FunctionDef]
+    ScopeNodeType = t.Union[ast.For, ast.While, ast.If, ast.Try, ast.TryStar, ast.FunctionDef, ast.AsyncFunctionDef]
     TryNodes = (ast.Try, ast.TryStar)
 
 
@@ -100,7 +100,7 @@ def __init__(self, component: t.Callable, use_functions=DEFAULT_USE_FUNCTIONS):
         parsed = ast.parse(parsed_source)
         # Get nodes from inside the function body
         func_definition = t.cast(ast.FunctionDef, parsed.body[0])
-        self.function_scope: ast.FunctionDef = func_definition
+        self.function_scope: t.Union[ast.FunctionDef, ast.AsyncFunctionDef] = func_definition
         self._root_function_scope = self.function_scope
         # None means, *DO* qa
         self.no_qa: t.Optional[t.Set[InvalidReactivityCause]] = None
@@ -129,7 +129,7 @@ def node_to_scope_cause(self, node: ScopeNodeType) -> InvalidReactivityCause:
             return InvalidReactivityCause.CONDITIONAL_USE
         elif isinstance(node, (ast.For, ast.While)):
             return InvalidReactivityCause.LOOP_USE
-        elif isinstance(node, ast.FunctionDef):
+        elif isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef)):
             return InvalidReactivityCause.NESTED_FUNCTION_USE
         elif isinstance(node, TryNodes):
             return InvalidReactivityCause.EXCEPTION_USE
@@ -175,6 +175,12 @@ def visit_FunctionDef(self, node: ast.FunctionDef):
         self._visit_children_using_scope(node)
         self.function_scope = old_function_scope
 
+    def visit_AsyncFunctionDef(self, node: ast.AsyncFunctionDef):
+        old_function_scope = self.function_scope
+        self.function_scope = node
+        self._visit_children_using_scope(node)
+        self.function_scope = old_function_scope
+
     def _visit_children_using_scope(self, node: ScopeNodeType):
         outer_scope = self.outer_scope
         self.outer_scope = node
diff --git a/tests/unit/hook_use_invalid_test.py b/tests/unit/hook_use_invalid_test.py
@@ -120,6 +120,13 @@ def Page3(  # noqa: SH101
         return
         solara.use_state(1)
 
+    @solara.component
+    def Page4():
+        async def inner_function():
+            return
+
+        solara.use_state(1)
+
 
 def test_hook_use_nested_function():
     # sometimes we know that the use of a hook is stable, even when in a loop
