feat: support relative paths in FileBrowser

maartenbreddels · maartenbreddels · commit 4b172244a721 · 2025-06-17T17:48:46.000+02:00
diff --git a/solara/components/file_browser.py b/solara/components/file_browser.py
@@ -114,7 +114,7 @@ def on_item(item, double_click):
                 on_path_select(None)
             return
         if item["name"] == "..":
-            new_dir = current_dir.value.parent
+            new_dir = current_dir.value.resolve().parent
             action_change_directory = (can_select and double_click) or (not can_select and not double_click)
             if action_change_directory and change_dir(new_dir):
                 if scroll_pos_stack:
@@ -164,7 +164,7 @@ def on_double_click(item):
 
     files = [{"name": "..", "is_file": False}] + list_dir(current_dir.value, filter=filter, directory_first=directory_first)
     with Div(class_="solara-file-browser") as main:
-        Div(children=[str(current_dir.value)])
+        Div(children=[str(current_dir.value.resolve())])
         FileListWidget.element(
             files=files,
             selected=selected,
diff --git a/tests/unit/file_browser_test.py b/tests/unit/file_browser_test.py
@@ -220,3 +220,16 @@ def set_directory(path: Path) -> None:
     names = {k["name"] for k in items}
     assert names != {"unit", "ui", "docs", "integration", "pyinstaller", ".."}
     assert mock.call_count == 1
+
+
+def test_file_browser_relative_path():
+    @solara.component
+    def Test():
+        return solara.FileBrowser(".")
+
+    div, rc = solara.render_fixed(Test())
+    list: solara.components.file_browser.FileListWidget = div.children[1]
+    files = {k["name"] for k in list.files}
+    list.test_click("..")
+    files_parent = {k["name"] for k in list.files}
+    assert files_parent != files
