fix: follow asgi spec and also check if text or bytes are None (Modal fix)

maartenbreddels · maartenbreddels · commit 396c58ac041c · 2025-04-25T17:54:40.000+02:00
We assumed when the text or bytes were None that it was a missing value,
but on Modal we do see a message like that, e.g.:
{'type': 'websocket.receive', 'bytes': b'...', 'text': None}}
diff --git a/solara/server/starlette.py b/solara/server/starlette.py
@@ -230,9 +230,9 @@ async def receive(self):
                 fut = self.portal.spawn_task(self.ws.receive)
 
             message = await asyncio.wrap_future(fut)
-        if "text" in message:
+        if message.get("text") is not None:
             return message["text"]
-        elif "bytes" in message:
+        elif message.get("bytes") is not None:
             return message["bytes"]
         elif message.get("type") == "websocket.disconnect":
             raise websocket.WebSocketDisconnect()
