Merged
Conversation
mariobuikhuizen
force-pushed
the
ci_release_as_solara-ipyantd
branch
from
6adcb85 to
481bd54
Compare
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Jun 5, 2024
When we define a esm top level in a module, we don't need to create the module widget. However, if we do this during the running of the app under the context of a virtual kernel, we should directly create the esm widget. Should fix the failing of widgetti/ipyantd#4
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Jun 5, 2024
When we define a esm top level in a module, we don't need to create the module widget. However, if we do this during the running of the app under the context of a virtual kernel, we should directly create the esm widget. Should fix the failing of widgetti/ipyantd#4
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Jun 6, 2024
When we define a esm top level in a module, we don't need to create the module widget. However, if we do this during the running of the app under the context of a virtual kernel, we should directly create the esm widget. Should fix the failing of widgetti/ipyantd#4
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Jun 6, 2024
When we define a esm top level in a module, we don't need to create the module widget. However, if we do this during the running of the app under the context of a virtual kernel, we should directly create the esm widget. Should fix the failing of widgetti/ipyantd#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.