This repository was archived by the owner on Nov 8, 2021. It is now read-only.
Install from latest release instead of master#133
Merged
michaelwittig merged 2 commits intowiddix:masterfrom Jun 27, 2018
Merged
Install from latest release instead of master#133michaelwittig merged 2 commits intowiddix:masterfrom
michaelwittig merged 2 commits intowiddix:masterfrom
Conversation
Make the install script idempotent by locking in the latest version number.
Contributor
|
Hi @AMeng We only have versioned RPMs at the moment. I don't like to hardcode the version because I'm the one who has to keep the version in sync. As you suggested, a argument to the install script that defaults to master would be much better. Would you be able to make the change in your PR? |
Contributor
Author
|
Added an option for specifying the release which defaults to |
michaelwittig
approved these changes
Jun 27, 2018
mukgupta
pushed a commit
to SvavaCapital/aws-ec2-ssh
that referenced
this pull request
Jul 31, 2018
Add argument to install script to specify release
Sigmonia
pushed a commit
to LabKey/aws-ec2-ssh
that referenced
this pull request
Feb 22, 2019
* if iam returns no users at all, it is likey down (implementation merged from https://github.com/packetfairy/aws-ec2-ssh/blob/condoms/import_users.sh#L285) fixes widdix#96 * Fix typo (widdix#125) * Fix typo in rpm install output text * Fix file name * fix * fix * improved check * re added creation policy * changing aws command line detection to make it silent (widdix#127) * fix RHEL * increase timeout * allow parallel tests * fix RHEL showcase * re-add creation policy * Update README.md bump version * added license to templates * Install from latest release instead of master (widdix#133) Add argument to install script to specify release * document ##ALL## * fix tag enabled groups in multi account setup (widdix#136) * added hint to AWS Systems Manager Session Manager * Changed URI for RPM to latest release version (widdix#140) * fix IAM SSH access * fix * Update README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the install script idempotent by locking in the latest version number. This value needs to be updated each time a new release is pushed out.
An alternative solution would be to pass in the release version as an argument to this script. I think even if this option was to be added, it should still default to the release from which the install script was taken.
Without this change, the install script cannot reliably be used for idempotent builds.