Repository navigation
fix(release): pin node-pty to its patched version - #7
Merged
Merged
Conversation
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The desktop app installs its packaged dependencies without a lockfile (
node-ptyis specified as^1.2.0-beta.15). That lockfile-free staged install resolved the newer1.2.0-beta.18release, which left our patch for1.2.0-beta.15unused — and pnpm fails on a patch that doesn't apply to the resolved version.Fix
node-pty: 1.2.0-beta.15override inpnpm-workspace.yaml(with a comment to keep it in sync withpatches/node-pty@*.patch).pnpm-lock.yamlaccordingly: the importer specifier changes from^1.2.0-beta.15to1.2.0-beta.15, pinned with its patch hash.Proof
Verified with the staged-install flow used when packaging the desktop app:
node-ptynow resolves to1.2.0-beta.15with the expected patch applied (patch_hash=f1e680afec85f650699ea756f91f469844ec4c976f4f168492a45c6b3f67d651), and the patch content matches the vendored patch file.Work performed by Kimi K3.1 Pro and Kimi K3-256K via T3 Code/pi.