Fix incumbent settings object handling#128
Merged
bzbarsky merged 1 commit intowhatwg:gh-pagesfrom Jun 15, 2016
domenic:prepare-callbacks
Merged
Fix incumbent settings object handling#128bzbarsky merged 1 commit intowhatwg:gh-pagesfrom domenic:prepare-callbacks
bzbarsky merged 1 commit intowhatwg:gh-pagesfrom
domenic:prepare-callbacks
Conversation
This is the counterpart to whatwg/html#1189, and properly calls in to HTML's new hooks to handle tracking the incumbent settings object using Web IDL's callback context mechanisms.
Collaborator
|
This looks good to me. Let me know whether you want me to just go ahead and merge it? |
Member
Author
|
Ready to merge this now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the counterpart to whatwg/html#1189, and properly calls in to HTML's new hooks to handle tracking the incumbent settings object using Web IDL's callback context mechanisms.