Editorial: Narrow ReadableStreamBYOBRequest.view to Uint8Array#1367
Merged
MattiasBuelens merged 3 commits intoApr 25, 2026
Merged
Conversation
Collaborator
Author
|
I don't think we will ever want to set I'm not sure if we need to file implementation bugs? This doesn't change anything about the generated glue code for browsers. Or maybe we should file them anyway, e.g. if Node.js wants to update the type in their JSDoc? |
annevk
approved these changes
Apr 12, 2026
annevk
left a comment
annevk
left a comment
Member
There was a problem hiding this comment.
This would improve the generated code slightly so it might be nice to file bugs, but it's not required as there's no observable difference.
This was referenced Apr 25, 2026
Collaborator
Author
|
Bugs have been filed. Does this need interest from implementers? It's a fairly trivial change, I don't expect anyone to be opposed to it. |
2 tasks
Member
|
I don’t think so. Technically not observable so up to your discretion. (WebKit is interested though in narrower typing generally.) |
Jah-yee
pushed a commit
to Jah-yee/node
that referenced
this pull request
Apr 25, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array. Fixes: nodejs#62952
bartlomieju
pushed a commit
to denoland/deno
that referenced
this pull request
Apr 25, 2026
…3477) ## Summary Per the spec change at [whatwg/streams#1367](whatwg/streams#1367), `ReadableStreamBYOBRequest.view` is always a `Uint8Array` — the BYOB controller already constructs it that way internally. Narrow the public type from `ArrayBufferView | null` to `Uint8Array<ArrayBuffer> | null`: - `cli/tsc/dts/lib.deno_web.d.ts` — the user-facing TypeScript declaration. - `ext/web/06_streams.js` — JSDoc on both the internal `[_view]` slot and the `view` getter. Before this PR, code like `const v: Uint8Array = req.view!` failed type-checking with TS2740 against `ArrayBufferView<ArrayBufferLike>`. After, it compiles and rejects assignment to incompatible views (e.g. `DataView`) with a meaningful TS2322. Fixes #33476.
Jah-yee
added a commit
to Jah-yee/node
that referenced
this pull request
Apr 29, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: nodejs#62952 Signed-off-by: Jah-yee <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
May 11, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: #62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: #63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
aduh95
pushed a commit
to nodejs/node
that referenced
this pull request
May 19, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: #62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: #63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
aduh95
pushed a commit
to nodejs/node
that referenced
this pull request
May 19, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: #62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: #63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
aduh95
pushed a commit
to nodejs/node
that referenced
this pull request
May 23, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: #62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: #63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
araujogui
pushed a commit
to araujogui/node
that referenced
this pull request
May 26, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: nodejs#62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: nodejs#63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
aduh95
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 18, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: #62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: #63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Jul 16, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: nodejs#62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: nodejs#63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Jul 16, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: nodejs#62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: nodejs#63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Jul 16, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: nodejs#62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: nodejs#63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
juanarbol
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 17, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: #62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: #63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
juanarbol
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 17, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: #62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: #63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
juanarbol
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 19, 2026
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: #62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: #63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadableStreamBYOBRequest.viewis always constructed as aUint8Arrayin the specification. Reflect this in the Web IDL.Fixes #1366.
ReadableStreamBYOBRequest.viewtoUint8Arraydenoland/deno#33476ReadableStreamBYOBRequest.viewtoUint8Arraynodejs/node#62952(See WHATWG Working Mode: Changes for more details.)
Preview | Diff